ismailsimsek commented on PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#issuecomment-1854653706
Thank you all for reviewing it, @amogh-jahagirdar should we also merge it to
1.4.x branch, for next release?
created PR for it if makes sense https://github.com/apache/iceberg/pul
amogh-jahagirdar merged PR #8340:
URL: https://github.com/apache/iceberg/pull/8340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
amogh-jahagirdar commented on PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#issuecomment-1854514510
Merging, thanks again for this fix @ismailsimsek and your follow-through.
Thanks for reviews @dramaticlly @nastra @rdblue
--
This is an automated message from the Apache Git S
dramaticlly commented on PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#issuecomment-1850721026
@rdblue @amogh-jahagirdar can you take another look? I think it's awesome if
we can merge this fix.
--
This is an automated message from the Apache Git Service.
To respond to the me
amogh-jahagirdar commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1419451962
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,76 @@ public void testDropNamespace() {
public void testCreateNamespa
amogh-jahagirdar commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1419451743
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,76 @@ public void testDropNamespace() {
public void testCreateNamespa
nastra commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1418975543
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,76 @@ public void testDropNamespace() {
public void testCreateNamespace() {
ismailsimsek commented on PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#issuecomment-1833943008
@nastra @Fokko if you have time, could you please review it too? it should
be ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dramaticlly commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1377104943
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,81 @@ public void testDropNamespace() {
public void testCreateNamespace()
ismailsimsek commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1375318438
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,81 @@ public void testDropNamespace() {
public void testCreateNamespace()
ismailsimsek commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1375318398
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,81 @@ public void testDropNamespace() {
public void testCreateNamespace()
rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1375317591
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,81 @@ public void testDropNamespace() {
public void testCreateNamespace() {
rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1375317481
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,81 @@ public void testDropNamespace() {
public void testCreateNamespace() {
rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1375317363
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,81 @@ public void testDropNamespace() {
public void testCreateNamespace() {
rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1375317106
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,81 @@ public void testDropNamespace() {
public void testCreateNamespace() {
ismailsimsek commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1371571888
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,81 @@ public void testDropNamespace() {
public void testCreateNamespace()
ismailsimsek commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1371566535
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -604,6 +604,27 @@ public void testCreateNamespace() {
// Test with no metadata
rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1367964162
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -604,6 +604,27 @@ public void testCreateNamespace() {
// Test with no metadata
catalo
ismailsimsek commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1367682226
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -604,6 +604,27 @@ public void testCreateNamespace() {
// Test with no metadata
ismailsimsek commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1367681786
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -345,19 +354,27 @@ public static String
deletePropertiesStatement(Set properties) {
static
dramaticlly commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1367320490
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -134,8 +134,13 @@ final class JdbcUtil {
+ " WHERE "
+ CATALOG_NAME
rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1367148848
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -345,19 +354,27 @@ public static String
deletePropertiesStatement(Set properties) {
static boole
rdblue commented on PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#issuecomment-1772957166
Thanks, @ismailsimsek! Looks a lot better now. I like the new fix using
ESCAPE. I think we just need to have more test cases now.
--
This is an automated message from the Apache Git Serv
rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1367147296
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -604,6 +604,27 @@ public void testCreateNamespace() {
// Test with no metadata
catalo
rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1367146172
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -604,6 +604,27 @@ public void testCreateNamespace() {
// Test with no metadata
catalo
ismailsimsek commented on PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#issuecomment-1772439329
@rdblue @dramaticlly resolved the issue with pure sql, and rolled back
previous changes. could you please review it again?
--
This is an automated message from the Apache Git Servi
ismailsimsek commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1366755414
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -345,38 +345,44 @@ public static String
deletePropertiesStatement(Set properties) {
static
rdblue commented on PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#issuecomment-1771876081
@ismailsimsek it looks like this has unnecessary changes and refactors quite
a bit. Can you revert the unnecessary changes and add to the PR description how
this solves the problem? Thank
rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1366272265
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -345,38 +345,44 @@ public static String
deletePropertiesStatement(Set properties) {
static boole
rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1366270788
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -345,38 +345,44 @@ public static String
deletePropertiesStatement(Set properties) {
static boole
rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1366270788
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -345,38 +345,44 @@ public static String
deletePropertiesStatement(Set properties) {
static boole
rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1366270299
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -135,7 +135,7 @@ final class JdbcUtil {
+ CATALOG_NAME
+ " = ? AND "
ismailsimsek commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1361153332
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -135,7 +135,7 @@ final class JdbcUtil {
+ CATALOG_NAME
+ " = ? AND "
dramaticlly commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1361000799
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -135,7 +135,7 @@ final class JdbcUtil {
+ CATALOG_NAME
+ " = ? AND "
amogh-jahagirdar commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1360982717
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -135,7 +135,7 @@ final class JdbcUtil {
+ CATALOG_NAME
+ " = ? AND "
35 matches
Mail list logo
