rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1366272265
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##########
@@ -345,38 +345,44 @@ public static String
deletePropertiesStatement(Set<String> properties) {
static boolean namespaceExists(
String catalogName, JdbcClientPool connections, Namespace namespace) {
- if (exists(
+ if (namespaceExists(
connections,
JdbcUtil.GET_NAMESPACE_SQL,
catalogName,
- JdbcUtil.namespaceToString(namespace) + "%")) {
+ JdbcUtil.namespaceToString(namespace))) {
return true;
}
- if (exists(
+ if (namespaceExists(
connections,
JdbcUtil.GET_NAMESPACE_PROPERTIES_SQL,
catalogName,
- JdbcUtil.namespaceToString(namespace) + "%")) {
+ JdbcUtil.namespaceToString(namespace))) {
return true;
}
return false;
}
@SuppressWarnings("checkstyle:NestedTryDepth")
- private static boolean exists(JdbcClientPool connections, String sql,
String... args) {
+ private static boolean namespaceExists(
+ JdbcClientPool connections, String sql, String catalogName, String
namespace) {
Review Comment:
I think you've misinterpreted the purpose of this method. This checks
whether any entity exists that matches the query -- whether there is at least
one record returned. I don't see any reason to change the fact that this method
is generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
