Fokko commented on code in PR #104:
URL: https://github.com/apache/iceberg-python/pull/104#discussion_r1457273376
##
mkdocs/docs/configuration.md:
##
@@ -195,6 +195,19 @@ catalog:
table-name: iceberg
```
+If you prefer to pass the credentials explicitly to the client ins
Fokko merged PR #104:
URL: https://github.com/apache/iceberg-python/pull/104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
waifairer commented on code in PR #104:
URL: https://github.com/apache/iceberg-python/pull/104#discussion_r1383886741
##
mkdocs/docs/configuration.md:
##
@@ -195,6 +195,19 @@ catalog:
table-name: iceberg
```
+If you prefer to pass the credentials explicitly to the client
HonahX commented on code in PR #104:
URL: https://github.com/apache/iceberg-python/pull/104#discussion_r1381205188
##
mkdocs/docs/configuration.md:
##
@@ -195,6 +195,19 @@ catalog:
table-name: iceberg
```
+If you prefer to pass the credentials explicitly to the client in
waifairer commented on code in PR #104:
URL: https://github.com/apache/iceberg-python/pull/104#discussion_r1380963042
##
pyiceberg/catalog/dynamodb.py:
##
@@ -110,7 +118,7 @@ def _dynamodb_table_exists(self) -> bool:
return False
except self.dynamodb.except
HonahX commented on code in PR #104:
URL: https://github.com/apache/iceberg-python/pull/104#discussion_r1380907420
##
pyiceberg/catalog/dynamodb.py:
##
@@ -110,7 +118,7 @@ def _dynamodb_table_exists(self) -> bool:
return False
except self.dynamodb.exception
HonahX commented on code in PR #104:
URL: https://github.com/apache/iceberg-python/pull/104#discussion_r1380909825
##
pyiceberg/catalog/dynamodb.py:
##
@@ -80,7 +80,15 @@
class DynamoDbCatalog(Catalog):
def __init__(self, name: str, **properties: str):
super().__i
waifairer commented on code in PR #104:
URL: https://github.com/apache/iceberg-python/pull/104#discussion_r1380715916
##
mkdocs/docs/configuration.md:
##
@@ -195,6 +195,19 @@ catalog:
table-name: iceberg
```
+If you prefer to pass the credentials explicitly to the client
waifairer commented on code in PR #104:
URL: https://github.com/apache/iceberg-python/pull/104#discussion_r1380715053
##
pyiceberg/catalog/dynamodb.py:
##
@@ -80,7 +80,15 @@
class DynamoDbCatalog(Catalog):
def __init__(self, name: str, **properties: str):
super().
Fokko commented on code in PR #104:
URL: https://github.com/apache/iceberg-python/pull/104#discussion_r1373726454
##
mkdocs/docs/configuration.md:
##
@@ -195,6 +195,19 @@ catalog:
table-name: iceberg
```
+If you prefer to pass the credentials explicitly to the client ins
HonahX commented on code in PR #104:
URL: https://github.com/apache/iceberg-python/pull/104#discussion_r1372446210
##
pyiceberg/catalog/dynamodb.py:
##
@@ -80,7 +80,15 @@
class DynamoDbCatalog(Catalog):
def __init__(self, name: str, **properties: str):
super().__i
waifairer commented on PR #104:
URL: https://github.com/apache/iceberg-python/pull/104#issuecomment-1779931470
Done, thanks @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
Fokko commented on PR #104:
URL: https://github.com/apache/iceberg-python/pull/104#issuecomment-1779912483
Thanks @waifairer for raising this! Could you also update the docs under
`mkdocs/docs/configuration.md`?
--
This is an automated message from the Apache Git Service.
To respond to th
waifairer opened a new pull request, #104:
URL: https://github.com/apache/iceberg-python/pull/104
Looks like Dynamo is lacking some properties which are documented for other
AWS-centric catalog types.
--
This is an automated message from the Apache Git Service.
To respond to the message,
14 matches
Mail list logo
