HonahX commented on code in PR #104:
URL: https://github.com/apache/iceberg-python/pull/104#discussion_r1380909825
##########
pyiceberg/catalog/dynamodb.py:
##########
@@ -80,7 +80,15 @@
class DynamoDbCatalog(Catalog):
def __init__(self, name: str, **properties: str):
super().__init__(name, **properties)
- self.dynamodb = boto3.client(DYNAMODB_CLIENT)
+ session = boto3.Session(
+ profile_name=properties.get("profile_name"),
+ region_name=properties.get("region_name"),
+ botocore_session=properties.get("botocore_session"),
+ aws_access_key_id=properties.get("aws_access_key_id"),
+ aws_secret_access_key=properties.get("aws_secret_access_key"),
+ aws_session_token=properties.get("aws_session_token"),
+ )
+ self.dynamodb = session.client(DYNAMODB_CLIENT)
Review Comment:
Thanks for adding the test!
##########
pyiceberg/catalog/dynamodb.py:
##########
@@ -110,7 +118,7 @@ def _dynamodb_table_exists(self) -> bool:
return False
except self.dynamodb.exceptions.InternalServerError as e:
raise GenericDynamoDbError(e.message) from e
-
+ print(response["Table"]["TableStatus"])
Review Comment:
Nit: could you please remove this print message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
