Re: [PR] Implement pre-existing session support for dynamodb catalog [iceberg-python]

[via GitHub]

Fokko commented on code in PR #104:
URL: https://github.com/apache/iceberg-python/pull/104#discussion_r1373726454


##########
mkdocs/docs/configuration.md:
##########
@@ -195,6 +195,19 @@ catalog:
     table-name: iceberg
 ```
 
+If you prefer to pass the credentials explicitly to the client instead of 
relying on environment variables,
+
+```yaml
+catalog:
+  default:
+    type: dynamodb
+    table-name: iceberg

Review Comment:
   Just noticed that we're mixing case here 😭 



##########
mkdocs/docs/configuration.md:
##########
@@ -195,6 +195,19 @@ catalog:
     table-name: iceberg
 ```
 
+If you prefer to pass the credentials explicitly to the client instead of 
relying on environment variables,
+
+```yaml
+catalog:
+  default:
+    type: dynamodb
+    table-name: iceberg

Review Comment:
   Just noticed that we're mixing case here 😭 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org