Re: [PR] HA HMS support [iceberg-python]

2024-09-25 Thread via GitHub
kevinjqliu merged PR #752: URL: https://github.com/apache/iceberg-python/pull/752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ice

Re: [PR] HA HMS support [iceberg-python]

2024-09-24 Thread via GitHub
awdavidson commented on code in PR #752: URL: https://github.com/apache/iceberg-python/pull/752#discussion_r1774140098 ## pyiceberg/catalog/hive.py: ## @@ -271,6 +271,19 @@ def __init__(self, name: str, **properties: str): DEFAULT_LOCK_CHECK_RETRIES, ) +

Re: [PR] HA HMS support [iceberg-python]

2024-09-24 Thread via GitHub
kevinjqliu commented on code in PR #752: URL: https://github.com/apache/iceberg-python/pull/752#discussion_r1774112353 ## pyiceberg/catalog/hive.py: ## @@ -271,6 +271,19 @@ def __init__(self, name: str, **properties: str): DEFAULT_LOCK_CHECK_RETRIES, ) +

Re: [PR] HA HMS support [iceberg-python]

2024-09-24 Thread via GitHub
kevinjqliu commented on code in PR #752: URL: https://github.com/apache/iceberg-python/pull/752#discussion_r1774066513 ## pyiceberg/catalog/hive.py: ## @@ -271,6 +271,19 @@ def __init__(self, name: str, **properties: str): DEFAULT_LOCK_CHECK_RETRIES, ) +

Re: [PR] HA HMS support [iceberg-python]

2024-08-11 Thread via GitHub
kevinjqliu commented on code in PR #752: URL: https://github.com/apache/iceberg-python/pull/752#discussion_r1713023492 ## tests/catalog/test_hive.py: ## @@ -1195,3 +1195,40 @@ def test_hive_wait_for_lock() -> None: with pytest.raises(WaitingForLockException): catal

Re: [PR] HA HMS support [iceberg-python]

2024-08-11 Thread via GitHub
kevinjqliu commented on code in PR #752: URL: https://github.com/apache/iceberg-python/pull/752#discussion_r1713023562 ## tests/catalog/test_hive.py: ## @@ -1195,3 +1195,40 @@ def test_hive_wait_for_lock() -> None: with pytest.raises(WaitingForLockException): catal

Re: [PR] HA HMS support [iceberg-python]

2024-08-11 Thread via GitHub
kevinjqliu commented on code in PR #752: URL: https://github.com/apache/iceberg-python/pull/752#discussion_r1713023492 ## tests/catalog/test_hive.py: ## @@ -1195,3 +1195,40 @@ def test_hive_wait_for_lock() -> None: with pytest.raises(WaitingForLockException): catal

Re: [PR] HA HMS support [iceberg-python]

2024-08-10 Thread via GitHub
awdavidson commented on code in PR #752: URL: https://github.com/apache/iceberg-python/pull/752#discussion_r1712607393 ## tests/catalog/test_hive.py: ## @@ -1195,3 +1195,40 @@ def test_hive_wait_for_lock() -> None: with pytest.raises(WaitingForLockException): catal

Re: [PR] HA HMS support [iceberg-python]

2024-08-09 Thread via GitHub
kevinjqliu commented on code in PR #752: URL: https://github.com/apache/iceberg-python/pull/752#discussion_r1711764892 ## tests/catalog/test_hive.py: ## @@ -1195,3 +1195,40 @@ def test_hive_wait_for_lock() -> None: with pytest.raises(WaitingForLockException): catal

Re: [PR] HA HMS support [iceberg-python]

2024-07-04 Thread via GitHub
awdavidson commented on PR #752: URL: https://github.com/apache/iceberg-python/pull/752#issuecomment-2209205175 > @awdavidson This looks like a nice addition. Could you add a test as well? Unit tests have been added -- This is an automated message from the Apache Git Service. To res

Re: [PR] HA HMS support [iceberg-python]

2024-07-04 Thread via GitHub
awdavidson commented on code in PR #752: URL: https://github.com/apache/iceberg-python/pull/752#discussion_r1665835337 ## pyiceberg/catalog/hive.py: ## @@ -271,6 +271,18 @@ def __init__(self, name: str, **properties: str): DEFAULT_LOCK_CHECK_RETRIES, ) +