awdavidson commented on code in PR #752: URL: https://github.com/apache/iceberg-python/pull/752#discussion_r1774140098
########## pyiceberg/catalog/hive.py: ########## @@ -271,6 +271,19 @@ def __init__(self, name: str, **properties: str): DEFAULT_LOCK_CHECK_RETRIES, ) + @staticmethod + def _create_hive_client(properties: Dict[str, str]) -> _HiveClient: + last_exception = None + for uri in properties["uri"].split(","): + try: + return _HiveClient(uri, properties.get("ugi")) + except BaseException as e: + last_exception = e + if last_exception is not None: + raise e + else: + raise ValueError(f"Unable to connect to hive using uri: {properties["uri"]}") Review Comment: 🤦 sorry - tomorrow will setup and double check from personal laptop (should have done this to start with) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org