awdavidson commented on code in PR #752:
URL: https://github.com/apache/iceberg-python/pull/752#discussion_r1665835337
##########
pyiceberg/catalog/hive.py:
##########
@@ -271,6 +271,18 @@ def __init__(self, name: str, **properties: str):
DEFAULT_LOCK_CHECK_RETRIES,
)
+ @staticmethod
+ def _create_hive_client(properties: Dict[str, str]) -> _HiveClient:
+ uris = properties["uri"].split(",")
+ for idx, uri in enumerate(uris):
+ try:
+ return _HiveClient(uri, properties.get("ugi"))
+ except BaseException as e:
+ if idx + 1 == len(uris):
+ raise e
+ else:
+ continue
Review Comment:
Rather than throwing a generic `ValueError` I have updated to capture and
throw the last exception if that code path is reached. Let me know what you
think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
