ilyasahsan123 closed pull request #9565: Flink v1.16: Switch Flink v1.16 tests
to Junit5 (Part 1)
URL: https://github.com/apache/iceberg/pull/9565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
nastra commented on code in PR #9565:
URL: https://github.com/apache/iceberg/pull/9565#discussion_r1469646130
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/reader/TestArrayBatchRecords.java:
##
@@ -50,19 +51,18 @@ private void testArray(
fileOff
nastra commented on code in PR #9565:
URL: https://github.com/apache/iceberg/pull/9565#discussion_r1469643916
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/sink/TestRowDataPartitionKey.java:
##
@@ -91,10 +92,10 @@ public void testNullPartitionValue() {
for (Ro
nastra commented on code in PR #9565:
URL: https://github.com/apache/iceberg/pull/9565#discussion_r1469642860
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/sink/TestAvroGenericRecordToRowDataMapper.java:
##
@@ -18,10 +18,11 @@
*/
package org.apache.iceberg.flink
nastra commented on code in PR #9565:
URL: https://github.com/apache/iceberg/pull/9565#discussion_r1469640535
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/sink/TestAvroGenericRecordToRowDataMapper.java:
##
@@ -18,10 +18,11 @@
*/
package org.apache.iceberg.flink
nastra commented on code in PR #9565:
URL: https://github.com/apache/iceberg/pull/9565#discussion_r1469638343
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/data/TestStructRowData.java:
##
@@ -22,7 +22,7 @@
import org.apache.iceberg.flink.DataGenerator;
import org
nastra commented on code in PR #9565:
URL: https://github.com/apache/iceberg/pull/9565#discussion_r1469635766
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestRowDataWrapper.java:
##
@@ -75,8 +75,8 @@ protected void generateAndValidate(Schema schema,
RecordWrappe
nastra commented on code in PR #9565:
URL: https://github.com/apache/iceberg/pull/9565#discussion_r1469634197
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestRowDataWrapper.java:
##
@@ -49,12 +49,12 @@ public void testTime() {
return;
nastra commented on code in PR #9565:
URL: https://github.com/apache/iceberg/pull/9565#discussion_r1469628869
##
flink/v1.18/build.gradle:
##
@@ -22,6 +22,10 @@ String scalaVersion = System.getProperty("scalaVersion") !=
null ? System.getPro
project(":iceberg-flink:iceberg-f
ilyasahsan123 commented on PR #9565:
URL: https://github.com/apache/iceberg/pull/9565#issuecomment-1914620937
hi @nastra , I've addressed your suggestion. Could you please take another
look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
ilyasahsan123 commented on PR #9565:
URL: https://github.com/apache/iceberg/pull/9565#issuecomment-1914437348
Sure, I will do it. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
nastra commented on PR #9565:
URL: https://github.com/apache/iceberg/pull/9565#issuecomment-1914388103
@ilyasahsan123 we typically apply such changes on the latest version first
(1.18) and then backport them in a separate PR. Could you apply these changes
to Flink 1.18 first please?
--
T
12 matches
Mail list logo
