nastra commented on code in PR #9565:
URL: https://github.com/apache/iceberg/pull/9565#discussion_r1469635766
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestRowDataWrapper.java:
##########
@@ -75,8 +75,8 @@ protected void generateAndValidate(Schema schema,
RecordWrapperTest.AssertMethod
StructLikeWrapper actualWrapper =
StructLikeWrapper.forType(schema.asStruct());
StructLikeWrapper expectedWrapper =
StructLikeWrapper.forType(schema.asStruct());
for (int i = 0; i < numRecords; i++) {
- Assert.assertTrue("Should have more records", actual.hasNext());
- Assert.assertTrue("Should have more RowData", expected.hasNext());
+ assertThat(actual.hasNext()).as("Should have more records").isTrue();
Review Comment:
```suggestion
assertThat(actual).as("Should have more records").hasNext();
```
same for the other places that use a similar pattern. We want to avoid using
isTrue/isFalse as much as possible, because we want to get rich context from
AssertJ when the assertion ever fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
