nastra commented on code in PR #9565:
URL: https://github.com/apache/iceberg/pull/9565#discussion_r1469646130
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/reader/TestArrayBatchRecords.java:
##########
@@ -50,19 +51,18 @@ private void testArray(
fileOffset,
startingRecordOffset);
- Assert.assertEquals(splitId, recordsWithSplitIds.nextSplit());
+ assertThat(splitId).isEqualTo(recordsWithSplitIds.nextSplit());
for (int i = 0; i < numberOfRecords; i++) {
RecordAndPosition<String> recAndPos =
recordsWithSplitIds.nextRecordFromSplit();
- Assert.assertEquals(elements[i], recAndPos.record());
- Assert.assertEquals(fileOffset, recAndPos.fileOffset());
- // recordOffset points to the position after this one
- Assert.assertEquals(startingRecordOffset + i + 1,
recAndPos.recordOffset());
+ assertThat(elements[i]).isEqualTo(recAndPos.record());
+ assertThat(fileOffset).isEqualTo(recAndPos.fileOffset());
Review Comment:
I think actual/expected are in the wrong order here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
