stevenzwu commented on PR #10881:
URL: https://github.com/apache/iceberg/pull/10881#issuecomment-2271607408
thanks @pvary for the review. Did `rebase and merge` to preserve the
Individual commits
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
stevenzwu merged PR #10881:
URL: https://github.com/apache/iceberg/pull/10881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
pvary commented on code in PR #10881:
URL: https://github.com/apache/iceberg/pull/10881#discussion_r1705052375
##
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##
@@ -401,7 +401,6 @@ void createIcebergTable(ObjectPath tablePath,
ResolvedCatalogTabl
pvary commented on code in PR #10881:
URL: https://github.com/apache/iceberg/pull/10881#discussion_r1705051705
##
flink/v1.20/flink/src/jmh/java/org/apache/iceberg/flink/sink/shuffle/MapRangePartitionerBenchmark.java:
##
@@ -140,8 +139,7 @@ private static String randomString(Str
stevenzwu commented on PR #10881:
URL: https://github.com/apache/iceberg/pull/10881#issuecomment-2270358383
> Hi @stevenzwu Is it possible to keep the original commits and authors in
the newly introduced flink1.20 , so that people could easily to track how was
the current version iterated ?
openinx commented on PR #10881:
URL: https://github.com/apache/iceberg/pull/10881#issuecomment-2270324527
Hi @stevenzwu Is it possible to keep the original commits and authors in
the newly introduced flink1.20 , so that people could easily to track how was
the current version iterated ?
stevenzwu commented on code in PR #10881:
URL: https://github.com/apache/iceberg/pull/10881#discussion_r1704443576
##
flink/v1.19/flink/src/jmh/java/org/apache/iceberg/flink/sink/shuffle/MapRangePartitionerBenchmark.java:
##
@@ -66,6 +69,8 @@ public class MapRangePartitionerBenc
stevenzwu opened a new pull request, #10881:
URL: https://github.com/apache/iceberg/pull/10881
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,