pvary commented on code in PR #10881:
URL: https://github.com/apache/iceberg/pull/10881#discussion_r1705051705
##########
flink/v1.20/flink/src/jmh/java/org/apache/iceberg/flink/sink/shuffle/MapRangePartitionerBenchmark.java:
##########
@@ -140,8 +139,7 @@ private static String randomString(String prefix) {
buffer[i] = (byte)
CHARS.charAt(ThreadLocalRandom.current().nextInt(CHARS.length()));
}
- // CHARS is all ASCII
- return prefix + new String(buffer, StandardCharsets.US_ASCII);
+ return prefix + new String(buffer);
Review Comment:
Do we need to add this change to the 1.19 test as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
