stevenzwu commented on code in PR #10881:
URL: https://github.com/apache/iceberg/pull/10881#discussion_r1704443576
##########
flink/v1.19/flink/src/jmh/java/org/apache/iceberg/flink/sink/shuffle/MapRangePartitionerBenchmark.java:
##########
@@ -66,6 +69,8 @@ public class MapRangePartitionerBenchmark {
Types.NestedField.required(9, "name9", Types.StringType.get()));
private static final SortOrder SORT_ORDER =
SortOrder.builderFor(SCHEMA).asc("id").build();
+ private static final Comparator<StructLike> SORT_ORDER_COMPARTOR =
Review Comment:
there was jmh setup issue (not included) in 1.19. hence the code issue
wasn't caught earlier.
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSpeculativeExecutionSupport.java:
##########
@@ -165,7 +165,7 @@ private static Configuration configure() {
Configuration configuration = new Configuration();
configuration.set(CoreOptions.CHECK_LEAKED_CLASSLOADER, false);
configuration.set(RestOptions.BIND_PORT, "0");
- configuration.set(JobManagerOptions.SLOT_REQUEST_TIMEOUT, 5000L);
+ configuration.set(JobManagerOptions.SLOT_REQUEST_TIMEOUT,
Duration.ofSeconds(5));
Review Comment:
Flink changed the config option type from long to Duration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
