Re: [PR] Fixed force_virtual_addressing problem [iceberg-python]

2025-04-17 Thread via GitHub
Fokko merged PR #1923: URL: https://github.com/apache/iceberg-python/pull/1923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Fixed force_virtual_addressing problem [iceberg-python]

2025-04-17 Thread via GitHub
Fokko commented on code in PR #1923: URL: https://github.com/apache/iceberg-python/pull/1923#discussion_r2049488052 ## pyiceberg/io/pyarrow.py: ## @@ -408,7 +408,7 @@ def _initialize_oss_fs(self) -> FileSystem: "access_key": get_first_property_value(self.properties,

Re: [PR] Fixed force_virtual_addressing problem [iceberg-python]

2025-04-17 Thread via GitHub
helmiazizm commented on code in PR #1923: URL: https://github.com/apache/iceberg-python/pull/1923#discussion_r2049361189 ## pyiceberg/io/pyarrow.py: ## @@ -408,7 +408,7 @@ def _initialize_oss_fs(self) -> FileSystem: "access_key": get_first_property_value(self.proper

Re: [PR] Fixed force_virtual_addressing problem [iceberg-python]

2025-04-17 Thread via GitHub
helmiazizm commented on code in PR #1923: URL: https://github.com/apache/iceberg-python/pull/1923#discussion_r2049361189 ## pyiceberg/io/pyarrow.py: ## @@ -408,7 +408,7 @@ def _initialize_oss_fs(self) -> FileSystem: "access_key": get_first_property_value(self.proper

Re: [PR] Fixed force_virtual_addressing problem [iceberg-python]

2025-04-17 Thread via GitHub
helmiazizm commented on code in PR #1923: URL: https://github.com/apache/iceberg-python/pull/1923#discussion_r2049361189 ## pyiceberg/io/pyarrow.py: ## @@ -408,7 +408,7 @@ def _initialize_oss_fs(self) -> FileSystem: "access_key": get_first_property_value(self.proper

Re: [PR] Fixed force_virtual_addressing problem [iceberg-python]

2025-04-17 Thread via GitHub
Fokko commented on code in PR #1923: URL: https://github.com/apache/iceberg-python/pull/1923#discussion_r2049108649 ## pyiceberg/io/pyarrow.py: ## @@ -408,7 +408,7 @@ def _initialize_oss_fs(self) -> FileSystem: "access_key": get_first_property_value(self.properties,

Re: [PR] Fixed force_virtual_addressing problem [iceberg-python]

2025-04-17 Thread via GitHub
Fokko commented on code in PR #1923: URL: https://github.com/apache/iceberg-python/pull/1923#discussion_r2049108649 ## pyiceberg/io/pyarrow.py: ## @@ -408,7 +408,7 @@ def _initialize_oss_fs(self) -> FileSystem: "access_key": get_first_property_value(self.properties,

Re: [PR] Fixed force_virtual_addressing problem [iceberg-python]

2025-04-16 Thread via GitHub
helmiazizm commented on code in PR #1923: URL: https://github.com/apache/iceberg-python/pull/1923#discussion_r2048090964 ## pyiceberg/io/pyarrow.py: ## @@ -408,7 +408,7 @@ def _initialize_oss_fs(self) -> FileSystem: "access_key": get_first_property_value(self.proper

Re: [PR] Fixed force_virtual_addressing problem [iceberg-python]

2025-04-16 Thread via GitHub
Fokko commented on code in PR #1923: URL: https://github.com/apache/iceberg-python/pull/1923#discussion_r2047689979 ## pyiceberg/io/pyarrow.py: ## @@ -408,7 +408,7 @@ def _initialize_oss_fs(self) -> FileSystem: "access_key": get_first_property_value(self.properties,

Re: [PR] Fixed force_virtual_addressing problem [iceberg-python]

2025-04-16 Thread via GitHub
Fokko commented on code in PR #1923: URL: https://github.com/apache/iceberg-python/pull/1923#discussion_r2047668282 ## pyiceberg/io/pyarrow.py: ## @@ -408,7 +408,7 @@ def _initialize_oss_fs(self) -> FileSystem: "access_key": get_first_property_value(self.properties,

[PR] Fixed force_virtual_addressing problem [iceberg-python]

2025-04-15 Thread via GitHub
helmiazizm opened a new pull request, #1923: URL: https://github.com/apache/iceberg-python/pull/1923 # Rationale for this change This fix changed the behavior for both `_oss_fs` and `_s3_fs` to be able to parse `s3.force-virtual-addressing` correctly. # Are