helmiazizm commented on code in PR #1923:
URL: https://github.com/apache/iceberg-python/pull/1923#discussion_r2049361189
##########
pyiceberg/io/pyarrow.py:
##########
@@ -408,7 +408,7 @@ def _initialize_oss_fs(self) -> FileSystem:
"access_key": get_first_property_value(self.properties,
S3_ACCESS_KEY_ID, AWS_ACCESS_KEY_ID),
"secret_key": get_first_property_value(self.properties,
S3_SECRET_ACCESS_KEY, AWS_SECRET_ACCESS_KEY),
"session_token": get_first_property_value(self.properties,
S3_SESSION_TOKEN, AWS_SESSION_TOKEN),
- "region": get_first_property_value(self.properties, S3_REGION,
AWS_REGION),
+ "force_virtual_addressing": property_as_bool(self.properties,
S3_FORCE_VIRTUAL_ADDRESSING, True),
Review Comment:
Unlike S3 authentication, virtual addressing is mandatory in OSS. Not having
it set to `True` will always throw access denied error, hence why setting it to
`True` by default would make authentication easier for users in case if they
ever forget to set `s3.force-virtual-addressing` parameter to `True`. I also
don't think this setting for OSS will go away anytime soon as other
S3-compatible object storages are also using the same method, so this change
should be safe.
I still keep the `property_as_bool` function to make the authentication feel
as graceful in case if users insist on setting it to `False`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
