Fokko commented on code in PR #1923:
URL: https://github.com/apache/iceberg-python/pull/1923#discussion_r2047689979
##########
pyiceberg/io/pyarrow.py:
##########
@@ -408,7 +408,7 @@ def _initialize_oss_fs(self) -> FileSystem:
"access_key": get_first_property_value(self.properties,
S3_ACCESS_KEY_ID, AWS_ACCESS_KEY_ID),
"secret_key": get_first_property_value(self.properties,
S3_SECRET_ACCESS_KEY, AWS_SECRET_ACCESS_KEY),
"session_token": get_first_property_value(self.properties,
S3_SESSION_TOKEN, AWS_SESSION_TOKEN),
- "region": get_first_property_value(self.properties, S3_REGION,
AWS_REGION),
+ "force_virtual_addressing": property_as_bool(self.properties,
S3_FORCE_VIRTUAL_ADDRESSING, True),
Review Comment:
Looks like it breaks the tests:
```
# For oss scheme, user provided region is used instead
> assert
pyarrow_file_io.new_input(f"oss://{bucket_region[0]}/path/to/file")._filesystem.region
== user_provided_region
E AssertionError: assert 'us-east-1' == 'ap-southeast-1'
E - ap-southeast-1
E + us-east-1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
