Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

kevinjqliu commented on code in PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2048213266 ## tests/integration/test_deletes.py: ## @@ -467,21 +467,19 @@ def test_partitioned_table_positional_deletes_sequence_number(spark: SparkSessio assert s

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

kevinjqliu commented on code in PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2048195532 ## tests/integration/test_deletes.py: ## @@ -467,21 +467,19 @@ def test_partitioned_table_positional_deletes_sequence_number(spark: SparkSessio assert s

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

kevinjqliu commented on code in PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2048195204 ## tests/integration/test_deletes.py: ## @@ -467,21 +467,19 @@ def test_partitioned_table_positional_deletes_sequence_number(spark: SparkSessio assert s

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

Fokko commented on PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#issuecomment-2810618650 Thanks for the review @kevinjqliu 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

Fokko merged PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

Fokko commented on code in PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2044268567 ## tests/integration/test_deletes.py: ## @@ -467,21 +467,19 @@ def test_partitioned_table_positional_deletes_sequence_number(spark: SparkSessio assert snapsh

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

Fokko commented on code in PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2044253646 ## tests/integration/test_deletes.py: ## @@ -467,21 +467,19 @@ def test_partitioned_table_positional_deletes_sequence_number(spark: SparkSessio assert snapsh

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

Fokko commented on code in PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2044253646 ## tests/integration/test_deletes.py: ## @@ -467,21 +467,19 @@ def test_partitioned_table_positional_deletes_sequence_number(spark: SparkSessio assert snapsh

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

Fokko commented on code in PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2044186417 ## pyiceberg/table/snapshots.py: ## @@ -356,6 +357,11 @@ def update_snapshot_summaries( raise ValueError(f"Operation not implemented: {summary.operation}"

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

Fokko commented on code in PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2044183681 ## tests/integration/test_writes/test_writes.py: ## @@ -262,6 +262,100 @@ def test_summaries(spark: SparkSession, session_catalog: Catalog, arrow_table_wi }

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

kevinjqliu commented on code in PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2040215134 ## tests/integration/test_deletes.py: ## @@ -467,21 +467,19 @@ def test_partitioned_table_positional_deletes_sequence_number(spark: SparkSessio assert s

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

Fokko commented on code in PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2027376060 ## tests/integration/test_writes/test_writes.py: ## @@ -262,6 +262,100 @@ def test_summaries(spark: SparkSession, session_catalog: Catalog, arrow_table_wi }

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

Fokko commented on code in PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2027379456 ## pyiceberg/table/update/snapshot.py: ## @@ -236,7 +236,6 @@ def _summary(self, snapshot_properties: Dict[str, str] = EMPTY_DICT) -> Summary: return upd

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

Fokko commented on code in PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2027521950 ## pyiceberg/table/update/snapshot.py: ## @@ -236,7 +236,6 @@ def _summary(self, snapshot_properties: Dict[str, str] = EMPTY_DICT) -> Summary: return upd

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

Fokko commented on code in PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2027518680 ## pyiceberg/table/update/snapshot.py: ## @@ -236,7 +236,6 @@ def _summary(self, snapshot_properties: Dict[str, str] = EMPTY_DICT) -> Summary: return upd

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

Fokko commented on code in PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2027518680 ## pyiceberg/table/update/snapshot.py: ## @@ -236,7 +236,6 @@ def _summary(self, snapshot_properties: Dict[str, str] = EMPTY_DICT) -> Summary: return upd

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

kevinjqliu commented on code in PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2027386623 ## tests/integration/test_writes/test_writes.py: ## @@ -262,6 +262,100 @@ def test_summaries(spark: SparkSession, session_catalog: Catalog, arrow_table_wi

Re: [PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

kevinjqliu commented on code in PR #1879: URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2027360226 ## tests/integration/test_writes/test_writes.py: ## @@ -262,6 +262,100 @@ def test_summaries(spark: SparkSession, session_catalog: Catalog, arrow_table_wi

[PR] Fix the snapshot summary of a partial overwrite [iceberg-python]

Fokko opened a new pull request, #1879: URL: https://github.com/apache/iceberg-python/pull/1879 # Rationale for this change @kevinjqliu PTAL. I took the liberty of providing a fix for this since I was curious where this was coming from, hope you don't mind! I've cherry-picked your co