Fokko commented on code in PR #1879:
URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2027518680
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -236,7 +236,6 @@ def _summary(self, snapshot_properties: Dict[str, str] =
EMPTY_DICT) -> Summary:
return update_snapshot_summaries(
summary=Summary(operation=self._operation, **ssc.build(),
**snapshot_properties),
previous_summary=previous_snapshot.summary if previous_snapshot is
not None else None,
- truncate_full_table=self._operation == Operation.OVERWRITE,
Review Comment:
It looks like we also need to record the dropped entries:
```json
{
"engine-version": "3.5.5",
"added-data-files": "1",
"total-equality-deletes": "0",
"app-id": "local-1743703872146",
"added-records": "5",
"deleted-data-files": "1",
"deleted-records": "5",
"total-records": "5",
"spark.app.id": "local-1743703872146",
"removed-files-size": "750",
"changed-partition-count": "1",
"engine-name": "spark",
"total-position-deletes": "0",
"added-files-size": "750",
"total-delete-files": "0",
"iceberg-version": "Apache Iceberg 1.8.1 (commit
9ce0fcf0af7becf25ad9fc996c3bad2afdcfd33d)",
"total-files-size": "750",
"total-data-files": "1"
}
```
Let's get that fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
