kevinjqliu commented on code in PR #1879:
URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2048195204
##########
tests/integration/test_deletes.py:
##########
@@ -467,21 +467,19 @@ def
test_partitioned_table_positional_deletes_sequence_number(spark: SparkSessio
assert snapshots[2].summary == Summary(
Operation.OVERWRITE,
Review Comment:
taking another look this summary is correct,
```
{
'added-data-files': '1', # CoW replaced (delete+add) a data file
'added-files-size': '949',
'added-records': '2', # CoW removed 3 records and added 2 records
(effectively removing 1 record)
'changed-partition-count': '1', # change a single partition
'deleted-data-files': '1', # CoW replaced (delete+add) a data file
'deleted-records': '3', # CoW removed 3 records and added 2 records
(effectively removing 1 record)
'removed-files-size': '747',
'total-data-files': '2', # still 2 data files total, 1 per partition
'total-delete-files': '1', # positional delete from previous delete
'total-equality-deletes': '0',
'total-files-size': '3402',
'total-position-deletes': '1', # positional delete from previous
delete
'total-records': '4' # decrement previous total-records
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
