Re: [PR] Fix the TableIdentifier [iceberg-python]

2023-10-07 Thread via GitHub
Fokko merged PR #44: URL: https://github.com/apache/iceberg-python/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Fix the TableIdentifier [iceberg-python]

2023-10-07 Thread via GitHub
Fokko commented on code in PR #44: URL: https://github.com/apache/iceberg-python/pull/44#discussion_r1349476395 ## tests/test_integration.py: ## @@ -104,25 +104,25 @@ def table(catalog: Catalog) -> Table: @pytest.mark.integration def test_table_properties(table: Table) -> No

Re: [PR] Fix the TableIdentifier [iceberg-python]

2023-10-06 Thread via GitHub
amogh-jahagirdar commented on code in PR #44: URL: https://github.com/apache/iceberg-python/pull/44#discussion_r1349475349 ## tests/test_integration.py: ## @@ -104,25 +104,25 @@ def table(catalog: Catalog) -> Table: @pytest.mark.integration def test_table_properties(table: T

[PR] Fix the TableIdentifier [iceberg-python]

2023-10-06 Thread via GitHub
Fokko opened a new pull request, #44: URL: https://github.com/apache/iceberg-python/pull/44 We were sending a table identifier before in `['accounting', 'tax', 'invoices']`, but it has to be `{'namespace': ['accounting, 'tax'], 'name': 'invoices'}` 😭 -- This is an automated message from