Fokko commented on code in PR #44:
URL: https://github.com/apache/iceberg-python/pull/44#discussion_r1349476395
##########
tests/test_integration.py:
##########
@@ -104,25 +104,25 @@ def table(catalog: Catalog) -> Table:
@pytest.mark.integration
def test_table_properties(table: Table) -> None:
- assert table.properties == {}
+ assert table.properties == {'write.parquet.compression-codec': 'zstd'}
with table.transaction() as transaction:
transaction.set_properties(abc="🤪")
- assert table.properties == {"abc": "🤪"}
+ assert table.properties == {"abc": "🤪", 'write.parquet.compression-codec':
'zstd'}
with table.transaction() as transaction:
transaction.remove_properties("abc")
- assert table.properties == {}
+ assert table.properties == {'write.parquet.compression-codec': 'zstd'}
Review Comment:
Good point @amogh-jahagirdar Updated the code.
Can't wait for the new dictionary merge code `d1 | d2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
