amogh-jahagirdar commented on code in PR #44:
URL: https://github.com/apache/iceberg-python/pull/44#discussion_r1349475349
##########
tests/test_integration.py:
##########
@@ -104,25 +104,25 @@ def table(catalog: Catalog) -> Table:
@pytest.mark.integration
def test_table_properties(table: Table) -> None:
- assert table.properties == {}
+ assert table.properties == {'write.parquet.compression-codec': 'zstd'}
with table.transaction() as transaction:
transaction.set_properties(abc="🤪")
- assert table.properties == {"abc": "🤪"}
+ assert table.properties == {"abc": "🤪", 'write.parquet.compression-codec':
'zstd'}
with table.transaction() as transaction:
transaction.remove_properties("abc")
- assert table.properties == {}
+ assert table.properties == {'write.parquet.compression-codec': 'zstd'}
Review Comment:
Nit: I suppose we could just define a constant default properties set with
the compression codec set, and then just use that in all the tests except the
table properties test. The tables property test would be the union of the
DEFAULT properties and the "abc" property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
