Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-09 Thread via GitHub
Fokko merged PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
Fokko commented on code in PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1710012487 ## tests/integration/test_writes/test_writes.py: ## @@ -1309,3 +1309,27 @@ def test_table_v1_with_null_nested_namespace(session_catalog: Catalog, arrow_tab

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
Fokko commented on code in PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1710012487 ## tests/integration/test_writes/test_writes.py: ## @@ -1309,3 +1309,27 @@ def test_table_v1_with_null_nested_namespace(session_catalog: Catalog, arrow_tab

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
kevinjqliu commented on code in PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1709963961 ## tests/integration/test_writes/test_writes.py: ## @@ -1309,3 +1309,27 @@ def test_table_v1_with_null_nested_namespace(session_catalog: Catalog, arrow_tab

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
kevinjqliu commented on code in PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1709963961 ## tests/integration/test_writes/test_writes.py: ## @@ -1309,3 +1309,27 @@ def test_table_v1_with_null_nested_namespace(session_catalog: Catalog, arrow_tab

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
ndrluis commented on code in PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1709929378 ## pyiceberg/table/__init__.py: ## @@ -593,7 +593,9 @@ def delete(self, delete_filter: Union[str, BooleanExpression], snapshot_properti filtere

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
ndrluis commented on code in PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1709925255 ## tests/integration/test_writes/test_writes.py: ## @@ -1309,3 +1309,27 @@ def test_table_v1_with_null_nested_namespace(session_catalog: Catalog, arrow_tab

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
kevinjqliu commented on code in PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1709774974 ## pyiceberg/table/__init__.py: ## @@ -593,7 +593,9 @@ def delete(self, delete_filter: Union[str, BooleanExpression], snapshot_properti filt

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
sungwy commented on PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#issuecomment-2275958892 Hi @ndrluis - thanks for testing and fixing this tricky issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
sungwy commented on code in PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#discussion_r1709621567 ## tests/integration/test_writes/test_writes.py: ## @@ -1295,3 +1296,27 @@ def test_rest_catalog_with_empty_catalog_name_append_data(session_catalog: Catal

Re: [PR] Fix overwrite when filtering all the data [iceberg-python]

2024-08-08 Thread via GitHub
Minfante377 commented on PR #1023: URL: https://github.com/apache/iceberg-python/pull/1023#issuecomment-2275883097 Just wanted to confirm that I tried this out with the table that caused my issue #1020 and it works as expected -- This is an automated message from the Apache Git Service. T