Fokko merged PR #94:
URL: https://github.com/apache/iceberg-python/pull/94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Fokko commented on code in PR #94:
URL: https://github.com/apache/iceberg-python/pull/94#discussion_r1370091939
##
pyiceberg/expressions/__init__.py:
##
@@ -701,7 +701,7 @@ def bind(self, schema: Schema, case_sensitive: bool = True)
-> BoundLiteralPredi
def __eq__(self,
Fokko commented on code in PR #94:
URL: https://github.com/apache/iceberg-python/pull/94#discussion_r1367862862
##
pyiceberg/expressions/__init__.py:
##
@@ -701,7 +701,7 @@ def bind(self, schema: Schema, case_sensitive: bool = True)
-> BoundLiteralPredi
def __eq__(self,
danielcweeks opened a new pull request, #94:
URL: https://github.com/apache/iceberg-python/pull/94
The equality check was not checking to see if they were the same predicate
so:
```
assert StartsWith("foo", "data") == parser.parse("foo NOT LIKE 'data'")
```
would evaluate `St