Fokko commented on code in PR #94:
URL: https://github.com/apache/iceberg-python/pull/94#discussion_r1367862862
##########
pyiceberg/expressions/__init__.py:
##########
@@ -701,7 +701,7 @@ def bind(self, schema: Schema, case_sensitive: bool = True)
-> BoundLiteralPredi
def __eq__(self, other: Any) -> bool:
"""Return the equality of two instances of the LiteralPredicate
class."""
- if isinstance(other, LiteralPredicate):
+ if isinstance(other, self.__class__):
Review Comment:
This fix is for the `LiteralPredicate`, but there are more:
- Line 367 should also use `self.__class__` for `IsNull`, `IsNaN` etc.
- Can you add `self.__class__` to the `SetPredicate` on line 534.
- The `__eq__` of `NotIn` on line 667 can go (`In` doesn't have one either).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
