nastra merged PR #12301:
URL: https://github.com/apache/iceberg/pull/12301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
rshkv commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1961954538
##
api/src/test/java/org/apache/iceberg/TestFileFormat.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
nastra commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1961721456
##
api/src/test/java/org/apache/iceberg/TestFileFormat.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contrib
nastra commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1961715451
##
api/src/test/java/org/apache/iceberg/TestFileFormat.java:
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contrib
rshkv commented on PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#issuecomment-2668498523
@nastra let's merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rshkv commented on PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#issuecomment-2668495223
> Why do you need the file format to sign an URL?
I think that doesn't quite matter for this PR. But it helps us make granular
access decisions based on file type (e.g., treating me
pvary commented on PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#issuecomment-2667920120
> Yeah, I guess there's an argument to not use this method when you can rely
on a better source for the file type. For what it's worth, we use
`FileFormat#fromFileName` in remote signing
rshkv commented on PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#issuecomment-2666980115
> I understand that this PR is just a fix for an existing method, but I have
concerns about the original intention of the method. We are relying on the
filename to deduce the actual file
RussellSpitzer commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1960298991
##
api/src/test/java/org/apache/iceberg/TestFileFormat.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
rshkv commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1960257998
##
api/src/test/java/org/apache/iceberg/TestFileFormat.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
pvary commented on PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#issuecomment-2666203768
I understand that this PR is just a fix for an existing method, but I have
concerns about the original intention of the method. We are relying on the
filename to deduce the actual file fo
nastra commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1960017025
##
api/src/test/java/org/apache/iceberg/TestFileFormat.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contrib
RussellSpitzer commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1959970860
##
api/src/test/java/org/apache/iceberg/TestFileFormat.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
RussellSpitzer commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1959968903
##
api/src/main/java/org/apache/iceberg/FileFormat.java:
##
@@ -60,9 +60,10 @@ public String addExtension(String filename) {
public static FileFormat fromFi
nastra commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1959863413
##
api/src/main/java/org/apache/iceberg/FileFormat.java:
##
@@ -60,9 +60,10 @@ public String addExtension(String filename) {
public static FileFormat fromFileName(C
nastra commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1959859499
##
api/src/test/java/org/apache/iceberg/TestFileFormat.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contrib
nastra commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1959851767
##
api/src/test/java/org/apache/iceberg/TestFileFormat.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contrib
nastra commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1959182084
##
api/src/test/java/org/apache/iceberg/FileFormatTest.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contrib
ebyhr commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1958874825
##
api/src/test/java/org/apache/iceberg/FileFormatTest.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
rshkv commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1958818328
##
api/src/main/java/org/apache/iceberg/FileFormat.java:
##
@@ -60,9 +60,10 @@ public String addExtension(String filename) {
public static FileFormat fromFileName(Ch
rshkv commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1958812097
##
api/src/test/java/org/apache/iceberg/FileFormatTest.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
RussellSpitzer commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1958699822
##
api/src/main/java/org/apache/iceberg/FileFormat.java:
##
@@ -60,9 +60,10 @@ public String addExtension(String filename) {
public static FileFormat fromFi
RussellSpitzer commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1958697008
##
api/src/test/java/org/apache/iceberg/FileFormatTest.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
RussellSpitzer commented on code in PR #12301:
URL: https://github.com/apache/iceberg/pull/12301#discussion_r1958693758
##
api/src/test/java/org/apache/iceberg/FileFormatTest.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
rshkv opened a new pull request, #12301:
URL: https://github.com/apache/iceberg/pull/12301
Closes #12300.
`FileFormat#fromFileName` should account for file names that are shorter
than a file format extension.
--
This is an automated message from the Apache Git Service.
To respond t
25 matches
Mail list logo
