rshkv commented on PR #12301: URL: https://github.com/apache/iceberg/pull/12301#issuecomment-2666980115
> I understand that this PR is just a fix for an existing method, but I have concerns about the original intention of the method. We are relying on the filename to deduce the actual file format. This seems brittle to me. For example many of our test are generating parquet files without extensions. Yeah, I guess there's an argument to not use this method when you can rely on a better source for the file type. For what it's worth, we use `FileFormat#fromFileName` in remote signing where we just have the URL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
