nastra commented on code in PR #12301: URL: https://github.com/apache/iceberg/pull/12301#discussion_r1960017025
########## api/src/test/java/org/apache/iceberg/TestFileFormat.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import static org.assertj.core.api.Assertions.assertThat; + +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.FieldSource; + +class TestFileFormat { + + private static final Object[][] FILE_NAMES = + new Object[][] { + // Files with format + {"file.puffin", FileFormat.PUFFIN}, Review Comment: I've checked locally but the test cases that expect a valid file format all pass without the fix (meaning that they don't reproduce the original issue that was reported). The only test cases that fail is where we're expecting a `null` file format. That's why I'm suggesting to also test `x.orc` and so on, since all of those use cases that expect a valid file format won't fail and reproduce the original issue because they never actually reach the `metadata.json` file format during iteration, since they are matching a different file format earlier and thus the original issue isn't reproduced -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
