koenvo closed pull request #1947: Feat/simplify upsert
URL: https://github.com/apache/iceberg-python/pull/1947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
Fokko commented on code in PR #1947:
URL: https://github.com/apache/iceberg-python/pull/1947#discussion_r2056167122
##
tests/table/test_upsert.py:
##
@@ -478,8 +485,8 @@ def test_upsert_with_duplicate_rows_in_table(catalog:
Catalog) -> None:
schema=arrow_schema,
)
Fokko commented on code in PR #1947:
URL: https://github.com/apache/iceberg-python/pull/1947#discussion_r2056158865
##
tests/table/test_upsert.py:
##
@@ -369,18 +369,25 @@ def test_upsert_with_identifier_fields(catalog: Catalog)
-> None:
)
upd = tbl.upsert(df)
-
Fokko commented on code in PR #1947:
URL: https://github.com/apache/iceberg-python/pull/1947#discussion_r2056158865
##
tests/table/test_upsert.py:
##
@@ -369,18 +369,25 @@ def test_upsert_with_identifier_fields(catalog: Catalog)
-> None:
)
upd = tbl.upsert(df)
-
