Fokko commented on code in PR #1947:
URL: https://github.com/apache/iceberg-python/pull/1947#discussion_r2056167122
##########
tests/table/test_upsert.py:
##########
@@ -478,8 +485,8 @@ def test_upsert_with_duplicate_rows_in_table(catalog:
Catalog) -> None:
schema=arrow_schema,
)
- with pytest.raises(ValueError, match="Target table has duplicate rows,
aborting upsert"):
- _ = tbl.upsert(df)
+ # with pytest.raises(ValueError, match="Target table has duplicate rows,
aborting upsert"):
+ # _ = tbl.upsert(df)
Review Comment:
We should be able to let this test pass pretty easily:
https://github.com/apache/iceberg-python/blob/b85127e05b699f5e8f7acc1034b9f258fd209477/pyiceberg/table/upsert_util.py#L67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
