Fokko commented on code in PR #1947:
URL: https://github.com/apache/iceberg-python/pull/1947#discussion_r2056158865
##########
tests/table/test_upsert.py:
##########
@@ -369,18 +369,25 @@ def test_upsert_with_identifier_fields(catalog: Catalog)
-> None:
)
upd = tbl.upsert(df)
- expected_operations = [Operation.APPEND, Operation.OVERWRITE,
Operation.APPEND, Operation.APPEND]
+ expected_operations = [Operation.APPEND, Operation.OVERWRITE,
Operation.APPEND]
- assert upd.rows_updated == 1
+ assert upd.rows_updated == 2
assert upd.rows_inserted == 1
assert [snap.summary.operation for snap in tbl.snapshots() if snap.summary
is not None] == expected_operations
- # This should be a no-op
+ # This will update all 3 rows
Review Comment:
I don't think it is very nice to update rows that should not be updated 🤔 If
nothing changes, we should just skip over it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
