Re: [PR] Docs: Fix inconsistency in branching and tagging scenario [iceberg]

2024-10-29 Thread via GitHub
github-actions[bot] closed pull request #9968: Docs: Fix inconsistency in branching and tagging scenario URL: https://github.com/apache/iceberg/pull/9968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Docs: Fix inconsistency in branching and tagging scenario [iceberg]

2024-10-29 Thread via GitHub
github-actions[bot] commented on PR #9968: URL: https://github.com/apache/iceberg/pull/9968#issuecomment-2445551610 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Docs: Fix inconsistency in branching and tagging scenario [iceberg]

2024-10-22 Thread via GitHub
github-actions[bot] commented on PR #9968: URL: https://github.com/apache/iceberg/pull/9968#issuecomment-2430545185 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Docs: Fix inconsistency in branching and tagging scenario [iceberg]

2024-04-10 Thread via GitHub
bitsondatadev commented on code in PR #9968: URL: https://github.com/apache/iceberg/pull/9968#discussion_r1560201975 ## docs/docs/branching.md: ## @@ -49,20 +49,21 @@ Tags can be used for retaining important historical snapshots for auditing purpo The above diagram demonstrate

Re: [PR] Docs: Fix inconsistency in branching and tagging scenario [iceberg]

2024-04-06 Thread via GitHub
lawofcycles commented on PR #9968: URL: https://github.com/apache/iceberg/pull/9968#issuecomment-2041291407 @bitsondatadev While referring to your comments, I pushed new version to improve entire explanation for Historical Tags. I was aware of the following points. - assumptio

Re: [PR] Docs: Fix inconsistency in branching and tagging scenario [iceberg]

2024-03-25 Thread via GitHub
bitsondatadev commented on PR #9968: URL: https://github.com/apache/iceberg/pull/9968#issuecomment-2018058241 @lawofcycles Thanks for your patience and willingness to help here! I'd like to consider an alternative explanation. I think conflating version with days is a big part of the confus

Re: [PR] Docs: Fix inconsistency in branching and tagging scenario [iceberg]

2024-03-25 Thread via GitHub
lawofcycles commented on PR #9968: URL: https://github.com/apache/iceberg/pull/9968#issuecomment-2017455653 @bitsondatadev, thank you for your valuable feedback. I agree that the explanations on this page could be improved, especially around the creation and retention of weekly snapshots.

Re: [PR] Docs: Fix inconsistency in branching and tagging scenario [iceberg]

2024-03-24 Thread via GitHub
bitsondatadev commented on code in PR #9968: URL: https://github.com/apache/iceberg/pull/9968#discussion_r1537002725 ## docs/docs/branching.md: ## @@ -50,10 +50,10 @@ The above diagram demonstrates retaining important historical snapshot with the via Spark SQL. 1. Retain 1

Re: [PR] Docs: Fix inconsistency in branching and tagging scenario [iceberg]

2024-03-24 Thread via GitHub
bitsondatadev commented on PR #9968: URL: https://github.com/apache/iceberg/pull/9968#issuecomment-2017104828 @Fokko, I believe the wording on this page is not only inconsistent, but it is rather confusing as it seems to indicate that a catalog is actually handling the creation of weekly ta

Re: [PR] Docs: Fix inconsistency in branching and tagging scenario [iceberg]

2024-03-22 Thread via GitHub
bitsondatadev commented on PR #9968: URL: https://github.com/apache/iceberg/pull/9968#issuecomment-2015939651 I'm currently AFK, I'll test this tonight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Docs: Fix inconsistency in branching and tagging scenario [iceberg]

2024-03-22 Thread via GitHub
lawofcycles commented on PR #9968: URL: https://github.com/apache/iceberg/pull/9968#issuecomment-2015937292 @Fokko @bitsondatadev I would greatly appreciate it if you could kindly review this pull request. -- This is an automated message from the Apache Git Service. To respond to the m

[PR] Docs: Fix inconsistency in branching and tagging scenario [iceberg]

2024-03-15 Thread via GitHub
lawofcycles opened a new pull request, #9968: URL: https://github.com/apache/iceberg/pull/9968 There is an inconsistency between the explanation of the snapshot retention strategy and SQL code on EOW-1 scenario. The description mentions retaining 1 snapshot per week for 1 month, but the