lawofcycles opened a new pull request, #9968: URL: https://github.com/apache/iceberg/pull/9968
There is an inconsistency between the explanation of the snapshot retention strategy and SQL code on EOW-1 scenario. The description mentions retaining 1 snapshot per week for 1 month, but the SQL code sets the retention period to only 1 week. > Retain 1 snapshot per week for 1 month. This can be achieved by tagging the weekly snapshot and setting the tag retention to be a month. snapshots will be kept, and the branch reference itself will be retained for 1 week. > -- Create a tag for the first end of week snapshot. Retain the snapshot for a week ALTER TABLE prod.db.table CREATE TAG `EOW-01` AS OF VERSION 7 RETAIN 7 DAYS; Modify the description to match the SQL code Update the description to state that only the latest weekly snapshot is retained for 1 week. Clarify that the branch reference itself is also retained for 1 week. Please review the proposed changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
