bitsondatadev commented on PR #9968: URL: https://github.com/apache/iceberg/pull/9968#issuecomment-2017104828
@Fokko, I believe the wording on this page is not only inconsistent, but it is rather confusing as it seems to indicate that a catalog is actually handling the creation of weekly tags. > The above diagram demonstrates retaining important historical snapshot with the following retention policy, defined via Spark SQL. > > Retain 1 snapshot per week for 1 month. This can be achieved by tagging the weekly snapshot and setting the tag retention to be a month. snapshots will be kept, and the branch reference itself will be retained for 1 week. Also the "snapshots will be kept" needs cleaning up. @lawofcycles, great catch on the inconsistency and actually the wording here needs a bit of rework if you're willing to help us fix it. I'll add a review comment where this needs to be updated. I do want to get Fokko's input though if I somehow don't understand how branching and tagging works, but this page almost indicates something that isn't there and I want to make sure I'm correct in my assumption that this wouldn't somehow magically start creating snapshots every 7 versions (days in this example). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
