kevinjqliu merged PR #1269:
URL: https://github.com/apache/iceberg-python/pull/1269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
kevinjqliu commented on code in PR #1269:
URL: https://github.com/apache/iceberg-python/pull/1269#discussion_r1824783872
##
mkdocs/docs/configuration.md:
##
@@ -341,7 +341,7 @@ catalog:
!!! warning "Deprecated Properties"
-`profile_name`, `region_name`, `botocore_sessio
HonahX commented on code in PR #1269:
URL: https://github.com/apache/iceberg-python/pull/1269#discussion_r1823739460
##
mkdocs/docs/configuration.md:
##
@@ -341,7 +341,7 @@ catalog:
!!! warning "Deprecated Properties"
-`profile_name`, `region_name`, `botocore_session`,
kevinjqliu commented on code in PR #1269:
URL: https://github.com/apache/iceberg-python/pull/1269#discussion_r1823134378
##
pyiceberg/catalog/dynamodb.py:
##
@@ -102,18 +96,11 @@ def __init__(self, name: str, **properties: str):
super().__init__(name, **properties)
Fokko commented on code in PR #1269:
URL: https://github.com/apache/iceberg-python/pull/1269#discussion_r1822010467
##
pyiceberg/catalog/glue.py:
##
@@ -303,18 +297,11 @@ def __init__(self, name: str, **properties: Any):
super().__init__(name, **properties)
s
Fokko commented on code in PR #1269:
URL: https://github.com/apache/iceberg-python/pull/1269#discussion_r1822010035
##
pyiceberg/catalog/dynamodb.py:
##
@@ -102,18 +96,11 @@ def __init__(self, name: str, **properties: str):
super().__init__(name, **properties)
kevinjqliu opened a new pull request, #1269:
URL: https://github.com/apache/iceberg-python/pull/1269
Searching for `removed_in="0.8.0":
https://github.com/search?q=repo%3Aapache%2Ficeberg-python+removed_in%3D%220.8&type=code
Removed items:
* `DEPRECATED_PROPERTY_NAMES`
* `to_
kevinjqliu commented on PR #1269:
URL: https://github.com/apache/iceberg-python/pull/1269#issuecomment-2445456953
I think this might be the first time we're removing deprecated
functions/parameters from the library.
I'm a bit concerned about the `DEPRECATED_PROPERTY_NAMES` and whether pe