HonahX commented on code in PR #1269:
URL: https://github.com/apache/iceberg-python/pull/1269#discussion_r1823739460


##########
mkdocs/docs/configuration.md:
##########
@@ -341,7 +341,7 @@ catalog:
 <!-- prettier-ignore-start -->
 
 !!! warning "Deprecated Properties"
-    `profile_name`, `region_name`, `botocore_session`, `aws_access_key_id`, 
`aws_secret_access_key`, `aws_session_token` are deprecated and will be removed 
in 0.8.0:
+    `profile_name`, `region_name`, `botocore_session`, `aws_access_key_id`, 
`aws_secret_access_key`, `aws_session_token` are deprecated and removed in 
0.8.0:

Review Comment:
   Since these properties are removed, shall we say they are "Removed 
Properties"?
   
   We might also consider removing this warning (and the one below) and mention 
these removed properties in the release note, along with other removed 
properties/methods/.... 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to