Re: [PR] Deprecate for 0.8.0 release [iceberg-python]

[via GitHub]

kevinjqliu commented on code in PR #1269:
URL: https://github.com/apache/iceberg-python/pull/1269#discussion_r1824783872


##########
mkdocs/docs/configuration.md:
##########
@@ -341,7 +341,7 @@ catalog:
 <!-- prettier-ignore-start -->
 
 !!! warning "Deprecated Properties"
-    `profile_name`, `region_name`, `botocore_session`, `aws_access_key_id`, 
`aws_secret_access_key`, `aws_session_token` are deprecated and will be removed 
in 0.8.0:
+    `profile_name`, `region_name`, `botocore_session`, `aws_access_key_id`, 
`aws_secret_access_key`, `aws_session_token` are deprecated and removed in 
0.8.0:

Review Comment:
   Changed to `Removed Properties`
   
   I think its a good idea to leave it here, at least for this new release, so 
that people can look up why their old properties are no longer working 
   
   ![Screenshot 2024-10-31 at 9 25 13 
AM](https://github.com/user-attachments/assets/4f4d448c-eb91-4569-a92f-9153bdb9a260)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org