Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on PR #10176: URL: https://github.com/apache/iceberg/pull/10176#issuecomment-2377498681 Splitted this into two PRs as suggested. compute: https://github.com/apache/iceberg/pull/11146 Write: https://github.com/apache/iceberg/pull/11216 -- This

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat closed pull request #10176: Data: Add a util to read write partition stats URL: https://github.com/apache/iceberg/pull/10176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1777461986 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on PR #10176: URL: https://github.com/apache/iceberg/pull/10176#issuecomment-2343906548 > I just learned that there is an ongoing effort to support writes with the internal Iceberg object model, which will nicely solve this problem for us (given that it is already in

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1741651006 ## core/src/main/java/org/apache/iceberg/data/PartitionStatsRecord.java: ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on PR #10176: URL: https://github.com/apache/iceberg/pull/10176#issuecomment-2316864310 > Add PartitionStatsWriter that would wrap PartitionStats as Record This abstraction isn't working out. Because `PartitionStats` need partition as `PartitionData` and `Rec

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on PR #10176: URL: https://github.com/apache/iceberg/pull/10176#issuecomment-2311678409 > Add a wrapper class to represent partition stats in core. I didn't use the wrapper class initially and directly used record because for each entry having two objects (wrapp

Re: [PR] Data: Add a util to read write partition stats [iceberg]

aokolnychyi commented on PR #10176: URL: https://github.com/apache/iceberg/pull/10176#issuecomment-2307890941 I took a detailed look at the implementation/spec today. Here are my high-level points: - The local algorithm was the right choice. I am on board with using `ConcurrentHashMa

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1729159956 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

aokolnychyi commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1728009901 ## data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Data: Add a util to read write partition stats [iceberg]

aokolnychyi commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1728009901 ## data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Data: Add a util to read write partition stats [iceberg]

aokolnychyi commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1727994442 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Data: Add a util to read write partition stats [iceberg]

aokolnychyi commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1727966586 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Data: Add a util to read write partition stats [iceberg]

aokolnychyi commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1727901172 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Data: Add a util to read write partition stats [iceberg]

aokolnychyi commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1727881929 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Data: Add a util to read write partition stats [iceberg]

aokolnychyi commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1727881929 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on PR #10176: URL: https://github.com/apache/iceberg/pull/10176#issuecomment-2301167087 Thanks @RussellSpitzer for the review. I have updated the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1724417472 ## data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1724415060 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsGenerator.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1723873509 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsGenerator.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1723533548 ## data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1722931839 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1722735848 ## data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1722827850 ## data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1722738419 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsGenerator.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1722735848 ## data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1722723867 ## data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1722719791 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1722038556 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsGenerator.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721988655 ## data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721980729 ## data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721979347 ## data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721978424 ## data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721975924 ## core/src/main/java/org/apache/iceberg/data/IdentityPartitionConverters.java: ## @@ -48,6 +50,13 @@ public static Object convertConstant(Type type, Object v

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721966029 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721957929 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721954085 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721885650 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721885650 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on PR #10176: URL: https://github.com/apache/iceberg/pull/10176#issuecomment-2292897105 Thanks a lot for the review @lirui-apache, I hope we can get this in after a review from @RussellSpitzer and @aokolnychyi. -- This is an automated message from the Apa

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on PR #10176: URL: https://github.com/apache/iceberg/pull/10176#issuecomment-2285486800 ping @aokolnychyi, @RussellSpitzer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1714692537 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1714691005 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsWriterUtil.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1714682727 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1711350427 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsGenerator.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1711350427 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsGenerator.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1711348696 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsWriterUtil.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

karuppayya commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1704749308 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsGenerator.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add a util to read write partition stats [iceberg]

lirui-apache commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1705560828 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsWriterUtil.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on PR #10176: URL: https://github.com/apache/iceberg/pull/10176#issuecomment-2271191550 @aokolnychyi , @RussellSpitzer, @lirui-apache: Please take another look at the PR. I have addressed all the comments. -- This is an automated message from the Apache Git Servi

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1705461680 ## data/src/main/java/org/apache/iceberg/data/GeneratePartitionStats.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1701879499 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on PR #10176: URL: https://github.com/apache/iceberg/pull/10176#issuecomment-2261017015 Thanks @RussellSpitzer, @aokolnychyi and @lirui-apache for the review feedbacks. I have also added strong test validations today. I have addressed or replied to each comm

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1698508423 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1698471050 ## data/src/main/java/org/apache/iceberg/data/GeneratePartitionStats.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1698436823 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1698404347 ## data/src/main/java/org/apache/iceberg/data/GeneratePartitionStats.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1698398597 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1698339815 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1698339571 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1698116352 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1698068822 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1698068822 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1698066417 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1697992679 ## data/src/main/java/org/apache/iceberg/data/GeneratePartitionStats.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Data: Add a util to read write partition stats [iceberg]

lirui-apache commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1697840726 ## data/src/main/java/org/apache/iceberg/data/GeneratePartitionStats.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Data: Add a util to read write partition stats [iceberg]

aokolnychyi commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1697760344 ## data/src/main/java/org/apache/iceberg/data/GeneratePartitionStats.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add a util to read write partition stats [iceberg]

aokolnychyi commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1697730639 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Data: Add a util to read write partition stats [iceberg]

aokolnychyi commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1697297242 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Data: Add a util to read write partition stats [iceberg]

aokolnychyi commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1697282703 ## core/src/main/java/org/apache/iceberg/BaseScan.java: ## @@ -289,4 +289,22 @@ private static Schema lazyColumnProjection(TableScanContext context, Schema sche

Re: [PR] Data: Add a util to read write partition stats [iceberg]

aokolnychyi commented on PR #10176: URL: https://github.com/apache/iceberg/pull/10176#issuecomment-2258726699 I should finally have some time today. @ajantha-bhat, is PR #9437 still valid as well? -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Data: Add a util to read write partition stats [iceberg]

lirui-apache commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1692587758 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1692581100 ## data/src/main/java/org/apache/iceberg/data/GeneratePartitionStats.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1692578855 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1692578140 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsWriterUtil.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Data: Add a util to read write partition stats [iceberg]

lirui-apache commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1691044481 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on PR #10176: URL: https://github.com/apache/iceberg/pull/10176#issuecomment-2245198784 @RussellSpitzer: Thanks for the review. I have addressed all the comments and added the mentioned tests. I have plan to add some more tests tomorrow (related to delete file stat

Re: [PR] Data: Add a util to read write partition stats [iceberg]

lirui-apache commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1687976550 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsWriterUtil.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1687927207 ## data/src/test/java/org/apache/iceberg/data/TestComputePartitionStats.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1687545473 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1687524246 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsWriterUtil.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1687515919 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

ajantha-bhat commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1682214561 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679833286 ## data/src/test/java/org/apache/iceberg/data/TestComputePartitionStats.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679828614 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsWriterUtil.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679828029 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsWriterUtil.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679827491 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsWriterUtil.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679815600 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsWriterUtil.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679810070 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsWriterUtil.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679809693 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsWriterUtil.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679728924 ## data/src/test/java/org/apache/iceberg/data/TestComputePartitionStats.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679727820 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsWriterUtil.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679714714 ## data/src/main/java/org/apache/iceberg/data/GeneratePartitionStats.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679698799 ## data/src/main/java/org/apache/iceberg/data/GeneratePartitionStats.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679689988 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679683800 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679666190 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679665205 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679653579 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Data: Add a util to read write partition stats [iceberg]

RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1679617189 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

  1   2   >