ajantha-bhat commented on PR #10176: URL: https://github.com/apache/iceberg/pull/10176#issuecomment-2261017015
Thanks @RussellSpitzer, @aokolnychyi and @lirui-apache for the review feedbacks. I have also added strong test validations today. I have addressed or replied to each comment. As per me, pending things are a) https://github.com/apache/iceberg/pull/10176#discussion_r1691044481, need to check about record converter and more unit tests for record converter for each data type. b) JMH benchmark for concurrent map logic to try out performance optimizations. I will check these tomorrow. Let me know if you can do another pass. Lets not lose momentum on this again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
