RussellSpitzer commented on code in PR #10176: URL: https://github.com/apache/iceberg/pull/10176#discussion_r1721988655
########## data/src/jmh/java/org/apache/iceberg/PartitionStatsGeneratorBenchmark.java: ########## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import static org.apache.iceberg.types.Types.NestedField.optional; +import static org.apache.iceberg.types.Types.NestedField.required; +import static org.assertj.core.api.Assertions.assertThat; + +import java.io.File; +import java.io.IOException; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.util.Comparator; +import java.util.concurrent.TimeUnit; +import java.util.stream.Stream; +import org.apache.iceberg.data.PartitionStatsGenerator; +import org.apache.iceberg.data.PartitionStatsWriterUtil; +import org.apache.iceberg.data.Record; +import org.apache.iceberg.io.CloseableIterable; +import org.apache.iceberg.types.Types; +import org.openjdk.jmh.annotations.Benchmark; +import org.openjdk.jmh.annotations.BenchmarkMode; +import org.openjdk.jmh.annotations.Fork; +import org.openjdk.jmh.annotations.Measurement; +import org.openjdk.jmh.annotations.Mode; +import org.openjdk.jmh.annotations.Scope; +import org.openjdk.jmh.annotations.Setup; +import org.openjdk.jmh.annotations.State; +import org.openjdk.jmh.annotations.TearDown; +import org.openjdk.jmh.annotations.Threads; +import org.openjdk.jmh.annotations.Timeout; +import org.openjdk.jmh.annotations.Warmup; + +@Fork(1) +@State(Scope.Benchmark) +@Warmup(iterations = 2) +@Measurement(iterations = 5) +@Timeout(time = 1000, timeUnit = TimeUnit.HOURS) +@BenchmarkMode(Mode.SingleShotTime) +public class PartitionStatsGeneratorBenchmark { + + private static final Schema SCHEMA = + new Schema( + required(1, "c1", Types.IntegerType.get()), + optional(2, "c2", Types.StringType.get()), + optional(3, "c3", Types.StringType.get())); + + protected static final PartitionSpec SPEC = + PartitionSpec.builderFor(SCHEMA).identity("c1").build(); + + private String baseDir; + + // create 3 manifests with same partition values + private static final int ITERATION_COUNTER = 3; + + // create 3 * 10000 manifests + private static final int PARTITION_COUNT = 10000; + + // one data file manifest + private static final int DATA_FILES_PER_PARTITION_COUNT = 1; + + private Table table; + + private PartitionStatisticsFile result; + + @Setup + public void setupBenchmark() throws IOException { + baseDir = + Paths.get(new File(System.getProperty("java.io.tmpdir")).getAbsolutePath()).toString(); + table = TestTables.create(new File(baseDir), "foo", SCHEMA, SPEC, SortOrder.unsorted(), 2); + + for (int interations = 0; interations < ITERATION_COUNTER; interations++) { + for (int partitionOrdinal = 0; partitionOrdinal < PARTITION_COUNT; partitionOrdinal++) { + StructLike partition = TestHelpers.Row.of(partitionOrdinal); + AppendFiles appendFiles = table.newAppend(); + for (int fileOrdinal = 0; fileOrdinal < DATA_FILES_PER_PARTITION_COUNT; fileOrdinal++) { + DataFile dataFile = FileGenerationUtil.generateDataFile(table, partition); + appendFiles.appendFile(dataFile); + } + + appendFiles.commit(); + } + } + } + + @TearDown + public void tearDownBenchmark() throws IOException { + // validate row count + try (CloseableIterable<Record> recordIterator = Review Comment: I don't think this is an appropriate place to assert that the benchmark ran correctly, one issue here is a failed run will not clean up the temp folder. Is there a reason to not place this in the benchmark itself? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
