Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-08-26 Thread via GitHub
wmoustafa commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1731884396 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issu

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-08-26 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1731814485 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-08-26 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1731815147 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-08-26 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1731814485 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-08-26 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1731813170 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-08-19 Thread via GitHub
wmoustafa commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1722654876 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issu

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-08-19 Thread via GitHub
wmoustafa commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1722654876 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issu

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-08-19 Thread via GitHub
wmoustafa commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1722654876 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issu

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-08-19 Thread via GitHub
aokolnychyi commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1722504135 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-08-19 Thread via GitHub
aokolnychyi commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1722501925 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-08-16 Thread via GitHub
wmoustafa commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1720492906 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issu

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-08-06 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1706006196 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-08-06 Thread via GitHub
amogh-jahagirdar commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1705996409 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-08-06 Thread via GitHub
aokolnychyi commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1705970013 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-31 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1699089811 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-30 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1697835615 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-29 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1695985484 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-29 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1695984822 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-29 Thread via GitHub
szehon-ho commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1695801167 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issu

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-29 Thread via GitHub
szehon-ho commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1695800041 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issu

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-29 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1695691508 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-29 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1695682400 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-29 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1695674936 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-29 Thread via GitHub
rdblue commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1695653411 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issue,

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-29 Thread via GitHub
rdblue commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1695651524 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issue,

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-29 Thread via GitHub
Fokko commented on PR #10780: URL: https://github.com/apache/iceberg/pull/10780#issuecomment-2255174333 > IIUC, this should get published to the central website. Maybe other repos can put a link in there contributing.md to reference this section once it gets published? Yes, that woul

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692309633 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
emkornfield commented on PR #10780: URL: https://github.com/apache/iceberg/pull/10780#issuecomment-2253589056 > As a side note, should this also be included in the subprojects' documentation, such as iceberg-python and iceberg-rust? IIUC, this should get published to the central websi

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693573999 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
RussellSpitzer commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693570087 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693523064 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693521805 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693521805 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693340621 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693348505 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693347926 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693346725 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693345805 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693340621 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693321326 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693320180 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
findepi commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693181862 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issue,

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
findepi commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r169317 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issue,

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
jbonofre commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693000980 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issue

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
jbonofre commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693000222 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issue

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
nastra commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692962578 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issue,

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
findepi commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692957089 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issue,

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
findepi commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692955888 ## site/docs/contribute.md: ## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issue,

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-26 Thread via GitHub
Fokko commented on PR #10780: URL: https://github.com/apache/iceberg/pull/10780#issuecomment-2252294519 > By the way, it would be also possible to update .asf.yml for "force" at least one review. I proposed to use labels (using modules/paths), assign reviewers per labels, force at least one

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692461358 ## site/docs/contribute.md: ## @@ -47,21 +47,10 @@ The Iceberg community prefers to receive contributions as [Github pull requests] ### Merging Pull Requests

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
liurenjie1024 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692457860 ## site/docs/contribute.md: ## @@ -47,21 +47,10 @@ The Iceberg community prefers to receive contributions as [Github pull requests] ### Merging Pull Request

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692454111 ## site/docs/contribute.md: ## @@ -47,21 +47,10 @@ The Iceberg community prefers to receive contributions as [Github pull requests] ### Merging Pull Requests

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
liurenjie1024 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692452864 ## site/docs/contribute.md: ## @@ -47,21 +47,10 @@ The Iceberg community prefers to receive contributions as [Github pull requests] ### Merging Pull Request

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692448337 ## site/docs/contribute.md: ## @@ -45,6 +45,28 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692444140 ## site/docs/contribute.md: ## @@ -45,6 +45,28 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692436679 ## site/docs/contribute.md: ## @@ -45,6 +45,28 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
liurenjie1024 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692413920 ## site/docs/contribute.md: ## @@ -45,6 +45,28 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692409107 ## site/docs/contribute.md: ## @@ -45,6 +45,28 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692405579 ## site/docs/contribute.md: ## @@ -45,6 +45,28 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
dimas-b commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692359926 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issue,

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692322916 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692320660 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692309633 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
emkornfield commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692308989 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an is

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
stevenzwu commented on PR #10780: URL: https://github.com/apache/iceberg/pull/10780#issuecomment-2251610150 > By the way, it would be also possible to update `.asf.yml` for "force" at least one review. I proposed to use labels (using modules/paths), assign reviewers per labels, force at lea

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692287235 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692275151 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
dimas-b commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692272718 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issue,

Re: [PR] DOC: Strawman proposal for PR merging [iceberg]

2024-07-25 Thread via GitHub
jackye1995 commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692267725 ## site/docs/contribute.md: ## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an iss