jbonofre commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1693000222
########## site/docs/contribute.md: ########## @@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issue, adding `Closes #1234` in the PR description will automatically close the issue and helps keep the project clean * If a PR is posted for visibility and isn't necessarily ready for review or merging, be sure to convert the PR to a draft +### Merging Pull Requests + +Most pull requests can be merged once a committer is satisfied with the code in the PR. Before merging all review comments should be addressed either by making changes or agreeing the request is out of scope for the PR. For larger changes or additions to public APIs committers will wait at least 24 hours before merging to ensure there is no additional feedback from members of the community. As in all ASF governed projects committers are expected to act in the best interest of the project. If a committer feels there might be a conflict of interest with a pull request they review, they are encouraged to ask for another committer to look at the pull request. + +A -1 vote on a PR (left as a comment with a reason attached) indicates a reviewer does not think the PR should be merged and that immediate changes by the PR author cannot address concerns. If the author and reviewer do not agree on the -1 vote, a discussion thread should be raised on the developer mailing list to come to a consensus on a path forward. One example where a -1 vote might be used is if a change should go through the [Iceberg improvement proposal](#apache-iceberg-improvement-proposals) process. Generally, -1 votes on PRs should be rare. Requesting changes on a PR indicates the reviewer believes the PR has merit but still needs issues addressed before merging. Reviewer in this context is anyone leaving comments on a PR, they can be a contributor, a committer or a PMC member. Review Comment: A PR is not strictly a vote, so I don't think -1 makes sense. If there's no consensus on a PR after requesting change, than, either the author close the PR, or he starts a vote on the dev mailing list. This vote would be consider like a code modification change, meaning veto is allowed, fragment vote is allowed as well. https://www.apache.org/foundation/voting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
