dimas-b commented on code in PR #10780: URL: https://github.com/apache/iceberg/pull/10780#discussion_r1692272718
########## site/docs/contribute.md: ########## @@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as [Github pull requests] * If a PR is related to an issue, adding `Closes #1234` in the PR description will automatically close the issue and helps keep the project clean * If a PR is posted for visibility and isn't necessarily ready for review or merging, be sure to convert the PR to a draft +### Merging Pull Requests + +Most pull requests can be merged once a committer is satisfied with the code in the PR. For larger changes or additions to public Review Comment: What about objections? To me it feels like people tend to regard a GH "request changes" review as a -1 in ASF terms, so those should probably be accompanied by a technical justification according to ASF [guidelines](https://www.apache.org/foundation/voting.html#Veto). Since most PR reviews happen in GitHub, would it be reasonable to explicitly link the GH "changes requested" option to ASF -1 Vetoes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
