nastra merged PR #11350:
URL: https://github.com/apache/iceberg/pull/11350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
leesf commented on PR #11350:
URL: https://github.com/apache/iceberg/pull/11350#issuecomment-2487135105
@nastra I pushed an update to fix the ut updated by your push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
nastra commented on code in PR #11350:
URL: https://github.com/apache/iceberg/pull/11350#discussion_r1848439678
##
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java:
##
@@ -205,6 +205,13 @@ public void testFailedCommit() throws Exception {
List manifests
pvary commented on code in PR #11350:
URL: https://github.com/apache/iceberg/pull/11350#discussion_r1848439698
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -368,7 +368,13 @@ private void renameToFinal(FileSystem fs, Path src, Path
dst, int n
nastra commented on code in PR #11350:
URL: https://github.com/apache/iceberg/pull/11350#discussion_r1848408316
##
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java:
##
@@ -205,6 +205,13 @@ public void testFailedCommit() throws Exception {
List manifests
leesf commented on PR #11350:
URL: https://github.com/apache/iceberg/pull/11350#issuecomment-2485769414
@Fokko hi, anything need to resolve here to merge the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
leesf commented on PR #11350:
URL: https://github.com/apache/iceberg/pull/11350#issuecomment-2462321487
@Fokko gentle ping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
leesf commented on PR #11350:
URL: https://github.com/apache/iceberg/pull/11350#issuecomment-2449690582
@Fokko I think the PR to good the merge, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
leesf commented on PR #11350:
URL: https://github.com/apache/iceberg/pull/11350#issuecomment-2446041222
> ./gradlew :iceberg-core:spotlessApply
Done and thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
Fokko commented on PR #11350:
URL: https://github.com/apache/iceberg/pull/11350#issuecomment-2445940060
@leesf Thanks! Can you run `./gradlew :iceberg-core:spotlessApply` to fix
the formatting? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message,
leesf commented on PR #11350:
URL: https://github.com/apache/iceberg/pull/11350#issuecomment-2445898551
> This makes sense. @leesf Could you add a test so we don't break this in
the future?
@Fokko Added check to the existing UT with dist file already exists failure.
--
This is an a
leesf commented on code in PR #11350:
URL: https://github.com/apache/iceberg/pull/11350#discussion_r1808917408
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -368,7 +368,13 @@ private void renameToFinal(FileSystem fs, Path src, Path
dst, int n
leesf commented on code in PR #11350:
URL: https://github.com/apache/iceberg/pull/11350#discussion_r1806229187
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -368,7 +368,13 @@ private void renameToFinal(FileSystem fs, Path src, Path
dst, int n
nastra commented on code in PR #11350:
URL: https://github.com/apache/iceberg/pull/11350#discussion_r1806163830
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -368,7 +368,13 @@ private void renameToFinal(FileSystem fs, Path src, Path
dst, int
leesf commented on PR #11350:
URL: https://github.com/apache/iceberg/pull/11350#issuecomment-2421372412
@rdblue please help to review this PR, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
leesf opened a new pull request, #11350:
URL: https://github.com/apache/iceberg/pull/11350
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
16 matches
Mail list logo
