nastra commented on code in PR #11350:
URL: https://github.com/apache/iceberg/pull/11350#discussion_r1848439678
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java:
##########
@@ -205,6 +205,13 @@ public void testFailedCommit() throws Exception {
List<File> manifests = listManifestFiles();
assertThat(manifests).as("Should contain 0 Avro manifest files").isEmpty();
+
+ // Verifies that there is no temporary metadata.json files left on dist
file already exists
+ // failures.
+ Set<String> actual =
+
listMetadataJsonFiles().stream().map(File::getName).collect(Collectors.toSet());
+ Set<String> expected = Sets.newHashSet("v1.metadata.json",
"v2.metadata.json");
+ assertThat(actual).as("only v1 and v2 metadata.json should
exist.").isEqualTo(expected);
Review Comment:
```suggestion
// verifies that there is no temporary metadata.json files left on disk
Set<String> actual =
listMetadataJsonFiles().stream().map(File::getName).collect(Collectors.toSet());
assertThat(actual)
.as("only v1 and v2 metadata.json should exist.")
.containsExactly("v1.metadata.json", "v2.metadata.json");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
