leesf commented on code in PR #11350:
URL: https://github.com/apache/iceberg/pull/11350#discussion_r1806229187
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##########
@@ -368,7 +368,13 @@ private void renameToFinal(FileSystem fs, Path src, Path
dst, int nextVersion) {
}
if (fs.exists(dst)) {
- throw new CommitFailedException("Version %d already exists: %s",
nextVersion, dst);
+ CommitFailedException cfe =
+ new CommitFailedException("Version %d already exists: %s",
nextVersion, dst);
+ RuntimeException re = tryDelete(src);
Review Comment:
@nastra yes, i think it is always safe to delete the temp src file(temp
metadata file), the commit retry would create a new temp metadata file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
