nastra merged PR #11151:
URL: https://github.com/apache/iceberg/pull/11151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
rdblue commented on PR #11151:
URL: https://github.com/apache/iceberg/pull/11151#issuecomment-2356600809
Thanks for the update! Looks good now. Please merge when tests are passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
nastra commented on code in PR #11151:
URL: https://github.com/apache/iceberg/pull/11151#discussion_r1763617159
##
core/src/test/java/org/apache/iceberg/TestTableMetadata.java:
##
@@ -1685,4 +1685,82 @@ public void testV3TimestampNanoTypeSupport() {
ImmutableMap.of(),
rdblue commented on code in PR #11151:
URL: https://github.com/apache/iceberg/pull/11151#discussion_r1763571115
##
core/src/test/java/org/apache/iceberg/TestTableMetadata.java:
##
@@ -1685,4 +1685,82 @@ public void testV3TimestampNanoTypeSupport() {
ImmutableMap.of(),
rdblue commented on code in PR #11151:
URL: https://github.com/apache/iceberg/pull/11151#discussion_r1763570028
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -964,6 +968,42 @@ private Builder(TableMetadata base) {
this.sortOrdersById = Maps.newHashMap
rdblue commented on code in PR #11151:
URL: https://github.com/apache/iceberg/pull/11151#discussion_r1763567963
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -578,6 +578,10 @@ public TableMetadata removeSnapshotsIf(Predicate
removeIf) {
return new Buil
nastra commented on code in PR #11151:
URL: https://github.com/apache/iceberg/pull/11151#discussion_r1762895735
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -578,6 +578,10 @@ public TableMetadata removeSnapshotsIf(Predicate
removeIf) {
return new Buil
nastra commented on code in PR #11151:
URL: https://github.com/apache/iceberg/pull/11151#discussion_r1762895735
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -578,6 +578,10 @@ public TableMetadata removeSnapshotsIf(Predicate
removeIf) {
return new Buil
