rdblue commented on code in PR #11151:
URL: https://github.com/apache/iceberg/pull/11151#discussion_r1763570028
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -964,6 +968,42 @@ private Builder(TableMetadata base) {
this.sortOrdersById = Maps.newHashMap(base.sortOrdersById);
}
+ private Builder(TableMetadata base, String metadataLocation) {
Review Comment:
I don't think that we need to duplicate the method above. Why not just
detect when there is a `null` value and change the logic accordingly?
Maintaining two copy constructors just introduces more places where a later
update can create bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
