nastra commented on code in PR #11151:
URL: https://github.com/apache/iceberg/pull/11151#discussion_r1762895735
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -578,6 +578,10 @@ public TableMetadata removeSnapshotsIf(Predicate<Snapshot>
removeIf) {
return new Builder(this).removeSnapshots(toRemove).build();
}
+ public TableMetadata updateMetadataLocation(String metadataFileLocation) {
Review Comment:
I decided to add this functionality to `TableMetadata` because we would
really only want to update the metadata location in this case and not do any
other updates that would require updating `lastUpdatedMillis`.
An alternative would be to have
```
public static Builder buildFrom(TableMetadata base, String
metadataFileLocation) {
return new Builder(base, metadataFileLocation);
}
```
but that would allow other method calls on the builder, which in turn would
also require updating `lastUpdatedMillis`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
